Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: call analysis scripts from python to reduce the number of reading trace data #161

Merged
merged 5 commits into from
Feb 24, 2024

Conversation

iwatake2222
Copy link
Collaborator

@iwatake2222 iwatake2222 commented Feb 21, 2024

  • Currently, make_report.sh calls python scripts which create each report. However, each python script reads CARET trace data by itself and it causes very long processing time especially when the trace data is huge
  • This PR adds a new python script which reads the trace data only once, then calls these scripts

iwatake2222 and others added 5 commits February 21, 2024 16:10
Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com>
Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com>
Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com>
…race data read

Signed-off-by: takeshi.iwanari <take.iwiw2222@gmail.com>
@iwatake2222
Copy link
Collaborator Author

@ohsawa1204
Could you review this PR?

@iwatake2222 iwatake2222 changed the title refactor: call analysis scripts from pythoon to reduce the number of trace data read refactor: call analysis scripts from python to reduce the number of trace data read Feb 21, 2024
@iwatake2222 iwatake2222 changed the title refactor: call analysis scripts from python to reduce the number of trace data read perf: call analysis scripts from python to reduce the number of trace data read Feb 21, 2024
@iwatake2222 iwatake2222 changed the title perf: call analysis scripts from python to reduce the number of trace data read perf: call analysis scripts from python to reduce the number of reading trace data Feb 21, 2024
@iwatake2222 iwatake2222 merged commit 47d45e4 into main Feb 24, 2024
10 of 12 checks passed
@iwatake2222 iwatake2222 deleted the fix_report_appearance branch February 24, 2024 10:40
Copy link
Contributor

@ohsawa1204 ohsawa1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iwatake2222
I got your changes. LGTM!
I'm so sorry to be late..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants